[MIG] l10n_uy_reports: Migration to 18.0 #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
from
cb8397c to
7c24be1
Compare
mem-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
from
7c24be1 to
88d6ddc
Compare
jue-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
2 times, most recently
from
a899e88 to
ef2a85e
Compare
jue-adhoc
reviewed
Dec 20, 2024
| @@ -199,7 +200,7 @@ def action_get_files(self): | |||
| if self.company_id.country_id.code != 'UY': | |||
| raise UserError(_("Solo puede generar este reporte para compañias Uruguayas")) | |||
|
|
|||
| data = getattr(self, '_get_form_%s_data' % self.uy_form_id)() | |||
| data = getattr(self, '_get_form_%s_data' % self.uy_form_id)() if self.uy_form_id else None | |||
There was a problem hiding this comment.
esto es porque el wizard tiene un campo selection para poner el formulario correspondiente, y si no seleccionabas ningun formulario saltaba un traceback
jue-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
3 times, most recently
from
ab5937b to
5a99a74
Compare
jue-adhoc
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Todos los cambios realizados sobre las queries y el uso de la tool SQL lo tomé de cambios realizados en l10n_ar_reports de Odoo enterprise
https://github.com/odoo/enterprise/commit/eeaa8d3b31d8efccd42b8705ba387527a39dfb57
jue-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
from
5a99a74 to
8cf46d2
Compare
| newUyVatBookTaxTypes[taxType]["selected"] = !newUyVatBookTaxTypes[taxType]["selected"]; | ||
| this.filterClicked({ optionKey: "uy_vat_book_tax_types_available", optionValue: newUyVatBookTaxTypes, reload: true}); | ||
| }, | ||
| }); |
| @@ -0,0 +1,27 @@ | |||
| import { _t } from "@web/core/l10n/translation"; | |||
There was a problem hiding this comment.
necesitamos esta línea?
| ).filter((type) => type.selected); | ||
|
|
||
| if (selectedTypes.length === availableTypes.length || selectedTypes.length === 0) { | ||
| return _t("All"); |
There was a problem hiding this comment.
Suggested change
| return _t("All"); | |
| return "All"; |
quizás habría que hacer esto?
jue-adhoc
force-pushed
the
18.0-mig-l10n_uy_reports
branch
from
8cf46d2 to
e369992
Compare
|
@roboadhoc r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.